amateurfunk/hamnet70
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

layer2_tx: Fixed stack-use-after-return

Browse source
This commit is contained in:
Thomas Kolb 2024-07-19 22:26:02 +02:00
parent 725a0ffd21
commit 041255e15f
1 changed files with 8 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
impl/src/layer2/layer2_tx.c
View file

@ -59,13 +59,20 @@ result_t layer2_tx_fill_packet_queue(layer2_tx_t *ctx)
// a packet is available -> move it to the queue // a packet is available -> move it to the queue
header.tx_seq_nr = ctx->next_seq_nr; header.tx_seq_nr = ctx->next_seq_nr;
uint8_t packetbuf[2048]; uint8_t *packetbuf = malloc(2048);
if(!packetbuf) {
LOG(LVL_ERR, "malloc failed.");
return ERR_NO_MEM;
}
ret = read(ctx->tun_fd, packetbuf, sizeof(packetbuf)); ret = read(ctx->tun_fd, packetbuf, sizeof(packetbuf));
if(ret < 0) { if(ret < 0) {
LOG(LVL_ERR, "read: %s", strerror(errno)); LOG(LVL_ERR, "read: %s", strerror(errno));
free(packetbuf);
return ERR_SYSCALL; return ERR_SYSCALL;
} else if(ret == 0) { } else if(ret == 0) {
// no more data // no more data
free(packetbuf);
break; break;
} }